Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

alert() popups should appear below tabs #6901

Closed
ayumi opened this issue Jan 28, 2017 · 3 comments · Fixed by #7107
Closed

alert() popups should appear below tabs #6901

ayumi opened this issue Jan 28, 2017 · 3 comments · Fixed by #7107
Assignees
@bsclifton
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include security
Milestone
0.13.5

Comments

@ayumi
Copy link
Contributor

ayumi commented Jan 28, 2017 •
edited by luixxiul
Loading

Test plan

#7107 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    JS alert() messages appear above the Line of Death, suggesting that alert messages are triggered by Brave the browser and not the webpage.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS 10.11.6

  • Brave Version (revision SHA):
    0.13.0 @ 8ca0127

  • Steps to reproduce:

    1. triggger a JS alert. you could open the dev console with Cmd+Alt+J then run alert("i love pyramids")

  • Actual result:

screen shot 2017-01-27 at 21 10 52

  • Expected result:
    Alert should appear entirely below browser tabs, within the webpage.
    Also probably shouldn't have a Lion icon.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Appendix A: Chrome

screen shot 2017-01-27 at 20 57 47

  • Appendix B: Firefox

screen shot 2017-01-27 at 21 05 11
@ayumi ayumi added the security label Jan 28, 2017
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 28, 2017 •
edited
Loading

bonus points for inter-mockup humor

@cndouglas
Copy link

Related issue: #2755 (prevent js alert spoofing attacks)

@luixxiul luixxiul added this to the 0.13.2 milestone Jan 28, 2017
@bsclifton bsclifton self-assigned this Feb 2, 2017
@bsclifton bsclifton modified the milestones: 0.13.3, 0.13.4 Feb 6, 2017
@bsclifton bsclifton mentioned this issue Feb 6, 2017
Merged
4 tasks
@bsclifton
Copy link
Member

Moving to 0.13.4

@bsclifton bsclifton modified the milestones: 0.13.4, 0.13.3 Feb 10, 2017
This was referenced Feb 11, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

Rework alert/confirm to be tab-modal (instead of application-modal)
7 participants
@ayumi @alexwykoff @luixxiul @bsclifton @bradleyrichter @srirambv @cndouglas