Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Re-add newtab background images (as an option) #6965

Closed
bbondy opened this issue Feb 1, 2017 · 2 comments
Closed

Re-add newtab background images (as an option) #6965

bbondy opened this issue Feb 1, 2017 · 2 comments

Comments

@bbondy
Copy link
Member

bbondy commented Feb 1, 2017

Test plan

  1. Launch Brave and visit about:preferences#tabs
  2. Default setting should be true
  3. Open new tab; verify backgrounds are shown
  4. Close new tab and change setting to false
  5. Open new tab; verify gradients are shown

Automated tests

npm run unittest -- --grep="NewTab component unit tests"

Original issue text

Because of high memory usage bug in chromium, background images on newtab page were removed here:
94a620a

This task is to track re-adding it, but this time as an option, and we can enable it by default once the memory problem is fixed.

@bbondy bbondy added this to the 0.13.3 milestone Feb 1, 2017
@dschwank
Copy link

dschwank commented Feb 6, 2017

+1 would be great to have this as an option!

@dschwank
Copy link

Yeah - the switch is implemented and works fine! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants