Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sanitizeTemplateItems should remove first item if it is a separator #7109

Closed
bbondy opened this issue Feb 6, 2017 · 5 comments · Fixed by #7228
Closed

sanitizeTemplateItems should remove first item if it is a separator #7109

bbondy opened this issue Feb 6, 2017 · 5 comments · Fixed by #7228

Comments

@bbondy
Copy link
Member

bbondy commented Feb 6, 2017

Also please add a test for it.

For example, on linux:
screenshot 2017-02-06 15 50 16

/cc @bsclifton

@siemiatj
Copy link
Contributor

siemiatj commented Feb 9, 2017

Lookng at the source :

if (result.length > 0 && result[0] === CommonMenu.separatorMenuItem) {
and tests :
it('does not allow the list to start with a separator', function () {
this should already be handled.

Maybe it's a linux thing ? The order of the items seems different if it's the latest build.

screen shot 2017-02-09 at 12 32 55 pm

@bbondy
Copy link
Member Author

bbondy commented Feb 10, 2017

Yes I think it only happens on Linux, each platform has a slightly different menu sometimes.

@bbondy
Copy link
Member Author

bbondy commented Feb 10, 2017

it does seem handled from code, interesting. I guess I'd have to dig in deeper on Ubuntu to see why it happened.

@cndouglas
Copy link

I can reproduce with Brave 0.12.13 RC 2 on macOS 10.12.x
image
There is an extra separator here:
https://github.com/brave/browser-laptop/blob/master/app/browser/menu.js#L430

@siemiatj
Copy link
Contributor

I'm wondering if it's not caused by the Search bar that is added for the Help tab. I can't really reproduce this in tests or in any other tab. Creating a PR that removes it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.