Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed crash caused by certain pinned tabs - Pin tabs which are loaded causes a crash #7187

Closed
luixxiul opened this issue Feb 11, 2017 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 11, 2017

Test plan

  1. Clear your brave folder
  2. Open https://github.com
  3. Click the menu on the page to open 4 tabs
  4. Pin all of them fast, before they are loaded completely
  5. Make sure the browser does not crash

Describe the issue you encountered:
Pinning tabs which are loaded causes a crash.

  • Platform (Win7, 8, 10? macOS? Linux distro?): WIndows 10 32 bit

  • Brave Version (revision SHA): 0.13.3 RC1

  • Steps to reproduce:

    1. Clear your brave folder
    2. Open https://github.com
    3. Click the menu on the page to open 4 tabs
    4. Pin all of them fast, before they are loaded completely
  • Actual result: the browser crashes

crash

  • Expected result: the browser should not crash

  • Will the steps above reproduce in a fresh profile? Yes

  • Can this issue be consistently reproduced? Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 11, 2017

If you pin tabs after they are loaded completely, the browser does not crash.

crash

@cndouglas
Copy link

I can't reproduce with 0.13.2. Probably introduced during 0.13.3.

@luixxiul luixxiul added this to the 0.13.4 milestone Feb 15, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul added this to the 0.13.6 milestone Feb 19, 2017
@bsclifton
Copy link
Member

Moving to 0.14.1 (aka 0.13.7)

@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 14, 2017
@bbondy
Copy link
Member

bbondy commented Apr 10, 2017

I think this crash should be gone now
#8084

@luixxiul
Copy link
Contributor Author

I cannot reproduce the error on the latest build.

@alexwykoff alexwykoff changed the title Pin tabs which are loaded causes a crash Fixed crash caused by certain pinned tabs Apr 25, 2017
@luixxiul luixxiul changed the title Fixed crash caused by certain pinned tabs Fixed crash caused by certain pinned tabs - Pin tabs which are loaded causes a crash Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.