Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave crashed on macOS 10.12.3 via.window.open() #7213

Closed
We5ter opened this issue Feb 13, 2017 · 6 comments
Closed

Brave crashed on macOS 10.12.3 via.window.open() #7213

We5ter opened this issue Feb 13, 2017 · 6 comments

Comments

@We5ter
Copy link

We5ter commented Feb 13, 2017

Test plan

  1. visit https://api.lightrains.org/poc/7.html
  2. click link
  3. verify alert shows and that Brave did not crash

Original issue description

  • Did you search for similar issues before submitting this one?

Yes

  • Describe the issue you encountered:

Brave crashed when visits poc.html

  • Platform (Win7, 8, 10? macOS? Linux distro?):

macOS10.12.3

  • Brave Version (revision SHA):

0.13.2

  • Steps to reproduce:
    1.poc script is:

<script>
function g(){

x=window; 
x.open('http://brave.com', 'z'); 
x.open('javascript:alert(1);', 'z'); 
}
</script>

CLICK ME

or visit online poc:

https://api.lightrains.org/poc/7.html

  • Actual result:

crashed

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

Yes

  • Can this issue be consistently reproduced?

Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@We5ter
Copy link
Author

We5ter commented Feb 13, 2017

POC script doesn't show as expected,Please view source at my online POC to see full script,Thanks.

@bbondy
Copy link
Member

bbondy commented Feb 13, 2017

cc @bridiver

@We5ter
Copy link
Author

We5ter commented Feb 14, 2017

Another crash POC:https://api.lightrains.org/poc/7-2.html

@bridiver
Copy link
Collaborator

only the first one crashes for me on 2.56.3

@bridiver
Copy link
Collaborator

I think the other crash will likely be fixed by @bsclifton's changes. @bsclifton can you verify?

@bsclifton bsclifton added this to the 0.13.5 milestone Feb 16, 2017
@bsclifton
Copy link
Member

bsclifton commented Feb 16, 2017

@bridiver verified; link is clicked, the alert is shown in a new about:blank tab 😄 (no crash)

Pulling into 0.13.5 as this will be fixed with #7107

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.