Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed incorrect state found in tab.pinned #7440

Closed
jonathansampson opened this issue Mar 2, 2017 · 2 comments
Closed

Fixed incorrect state found in tab.pinned #7440

jonathansampson opened this issue Mar 2, 2017 · 2 comments
Labels
bug feature/extensions feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@jonathansampson
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When querying tab objects via the chrome.tabs API, the pinned property does not accurately communicate whether or not a tab is presently pinned.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    0.13.4

  • Steps to reproduce:

    1. Navigate to, and pin, about:extensions
    2. Press Ctrl+Shift+I to open the developer tools, switch to Console
    3. Run chrome.tabs.getCurrent(tab => console.log(tab.pinned))

  • Actual result:
    The pinned value is false.

  • Expected result:
    The pinned value should be true.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
@jonathansampson jonathansampson added this to the 0.13.6 milestone Mar 2, 2017
@jonathansampson jonathansampson mentioned this issue Mar 2, 2017
Closed
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
@bbondy bbondy modified the milestones: 0.14.1, 0.14.0 Mar 16, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton
Copy link
Member

moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 7, 2017
@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 7, 2017
@bbondy bbondy modified the milestones: 0.14.2, 0.14.3 Apr 13, 2017
@bbondy
Copy link
Member

bbondy commented Apr 13, 2017

This actually already works with the detachable tabs merge. Closing and marking as 0.14.2.

@bbondy bbondy closed this as completed Apr 13, 2017
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
@bsclifton bsclifton removed the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Apr 14, 2017
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff changed the title Incorrect state found in tab.pinned Fixed incorrect state found in tab.pinned Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/extensions feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@jonathansampson @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv