Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Publisher icon not properly aligned with URL bar #7449

Closed
srirambv opened this issue Mar 2, 2017 · 1 comment
Closed

Publisher icon not properly aligned with URL bar #7449

srirambv opened this issue Mar 2, 2017 · 1 comment
Assignees
@cezaraugusto
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 2, 2017 •
edited by luixxiul
Loading

Test Plan

From #7455 (comment)

Go to a valid publisher url (i.e. brianbondy.com)

  • urlbar shouldn't have right borderRadius

Exclude that publisher

  • urlbar should have right borderRadius

Disable payments

  • urlbar should have right borderRadius

Go to an about page or other pages that shouldn't have publisherToggle (protocols other than HTTP)

  • urlbar should have right borderRadius

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Publisher icon in URL bar is not properly aligned with URL bar

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 0e68342

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto
    Please change milestone if required
@srirambv srirambv added feature/rewards polish Nice to have — usually related to front-end/visual tasks. release/not-blocking labels Mar 2, 2017
@srirambv srirambv added this to the 0.13.5 milestone Mar 2, 2017
@srirambv srirambv changed the title Publisher icon in URL bar is not properly aligned with URL bar Publisher icon not properly aligned with URL bar Mar 2, 2017
@cezaraugusto cezaraugusto mentioned this issue Mar 2, 2017
Merged
@srirambv
Copy link
Collaborator Author

srirambv commented Mar 3, 2017

Working as expected on 0.13.5 RC3

This was referenced Mar 3, 2017
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Aug 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
4 participants
@alexwykoff @cezaraugusto @bsclifton @srirambv