Add custom pinned site

[NejcZdovc]

Ability to add custom pinned site.
It's addition to the #7347 PR

When you click on Add, site is added, but dialog is not closed.
When you click on Done, dialog is closed and nothing is saved.

[mrose17]

i think this is a bad idea. when you pin a site because you've already gone there, we know (at least) that the URL is correct, etc.

second, what does it mean to pin a site that you never go to? that just seems... odd

@bradleyrichter - your thoughts?

[NejcZdovc]

@mrose17 This issue was created on @bradleyrichter request, he also provided mock for it

[mrose17]

@NejcZdovc - thanks. i still think it's a bad idea, so i'm interested in hearing @bradleyrichter's thinking on this.

[bsclifton]

Assigning to @bradleyrichter so he can provide more info (or close issue if he agrees with @mrose17 )

[cndouglas]

What is the use case for this? We don't have this kind of functionality with bookmarks, for example.

[NejcZdovc]

@bsclifton I think this is already defined. We defined it on the last ledger call. This is how you add custom publishers to the ledger. This publishers are pinned by default.

[davidtemkin]

Where I could see this, or something similar, being very useful is if we were to provide a link to publishers/creators that, if viewed in Brave, would result in a dialog like this. Right now a publisher/creator who'd like to promote Brave (and seek contributions from Brave users) has to explain or link to an explanation of pinning (which despite our familiarity with it, is not exactly self-evident); and then instruct users to perform a set of manual steps.

[tildelowengrimm]

@bsclifton Do we have this functionality in the new version, or is it "addressed" in the sense that it's probably no longer needed because other functionality covers all the applicable use cases?

[bsclifton]

@tomlowenthal I'm not sure of the specifics with Brave Rewards... but the entire system is overhauled. @NejcZdovc might know the answer offhand