Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed YouTube.com layout when blocking ads #7818

Closed
bbondy opened this issue Mar 21, 2017 · 4 comments
Closed

Fixed YouTube.com layout when blocking ads #7818

bbondy opened this issue Mar 21, 2017 · 4 comments
Assignees
@bbondy
Labels
feature/adblock QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@bbondy
Copy link
Member

bbondy commented Mar 21, 2017 •
edited by bsclifton
Loading

Test plan

  1. Visit www.youtube.com
  2. Watch videos which should have ads
  3. Empty div should not show (see image below)

Original issue details

Because of YouTubes popularity, apply css rules here.

screenshot 2017-03-21 15 10 21
@bbondy bbondy added this to the 0.14.1 milestone Mar 21, 2017
@luixxiul
Copy link
Contributor

On Japanese site I notice it too

@bbondy
Copy link
Member Author

bbondy commented Mar 27, 2017

Fixed by:
8600d22

@bbondy bbondy closed this as completed Mar 27, 2017
@bbondy bbondy modified the milestones: 0.14.0, 0.14.1 Mar 27, 2017
bbondy referenced this issue Mar 27, 2017
@bbondy
Apply CSS filtering on youtube.com
8600d22 
Fix:
brave/adblock-lists#3 (comment)

Auditors:
- @jonathansampson, @lukemulks: To see if the changes are OK and for
  checking www.washingtonpost.com and www.youtube.com still works ok
  with those added new rules.
- @clifton: To pull into 0.14.0 if possible
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
44 tasks
@luixxiul
Copy link
Contributor

luixxiul commented Mar 29, 2017 •
edited
Loading

On youtube.com I still see the placeholder.

clipboard01

And it seems that I am on the experimental version of youtube page. The page is basically built on the original tags like these:

clipboard01

@luixxiul luixxiul mentioned this issue Mar 29, 2017
Closed
4 tasks
@luixxiul
Copy link
Contributor

Here is the screenshot of the new dashboard on youtube.com.

clipboard01

This was referenced Mar 29, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff changed the title YouTube.com has big empty div placeholders for ads Fixed YouTube.com layout when blocking ads Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/adblock QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @bsclifton @srirambv