Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restart buttons need to have some visual indication of interaction #7968

Closed
alexwykoff opened this issue Mar 29, 2017 · 5 comments
Closed

Restart buttons need to have some visual indication of interaction #7968

alexwykoff opened this issue Mar 29, 2017 · 5 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. bug design A design change, especially one which needs input from the design team. wontfix

Comments

@alexwykoff
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When choosing 'Yes' from the restart notification bar, a few seconds would pass between the click and the restart. My first impression was that I didn't click or I missed the target.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Discovered on OS X

  • Brave Version (revision SHA):
    0.14.0 RC2 (b00c5d9)

  • Steps to reproduce:

    1. Open Preferences
    2. Change your language
    3. Click 'Yes' in the restart notification bar
    4. Observe the interaction
  • Actual result:
    On a busy system, there will be a considerable delay which makes it appear as though no user action occurred.

  • Expected result:
    Visual feedback should let the user know they hit the target and a restart is imminent.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Not sure

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@alexwykoff alexwykoff added the design A design change, especially one which needs input from the design team. label Mar 29, 2017
@alexwykoff alexwykoff added this to the 0.14.1 milestone Mar 29, 2017
@bsclifton
Copy link
Member

Moving to 0.14.3. Before we can handle this, we'll need to understand what we'd like the user to experience. cc: @bradleyrichter. Do we put a modal / overlay over the UI with a spinner?

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton bsclifton added the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Apr 4, 2017
@bradleyrichter
Copy link
Contributor

probably a good case for a modal because heading down a new path while waiting for the restart will only cause more frustration when it closes on you mid-click/read.

@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 7, 2017
@alexwykoff alexwykoff modified the milestones: Backlog, 0.15.1 Apr 18, 2017
@alexwykoff
Copy link
Contributor Author

A setTimeout might work so that we show an animation before the restart action kicks off

@luixxiul luixxiul added the bug label Jun 4, 2017
@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@I3uckwheat
Copy link

I can work on this! Could take me a bit to get familiar with what is going on with the code though!

@bsclifton bsclifton added wontfix and removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. labels Aug 13, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 13, 2018
@bsclifton bsclifton added addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Aug 13, 2018
@bsclifton
Copy link
Member

Closing as wontfix - this experience will change as we move to brave-core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. bug design A design change, especially one which needs input from the design team. wontfix
Projects
None yet
Development

No branches or pull requests

7 participants