Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Set the file type filter when presenting a save dialog #8096

Closed
jonathansampson opened this issue Apr 6, 2017 · 7 comments · Fixed by #11906
Closed

Set the file type filter when presenting a save dialog #8096

jonathansampson opened this issue Apr 6, 2017 · 7 comments · Fixed by #11906

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 6, 2017

Test plan

#11906 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When saving an image, Brave does not populate the Save as type value in the dialog.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10

  • Brave Version (revision SHA):
    3de60d5

  • Steps to reproduce:

    1. Navigate to https://i.imgur.com/3w0l0MM.png
    2. Right click, and select Save Image
    3. Note that Save as type is "All Files (*.*)" rather than "PNG Image"
  • Actual result:

image

  • Expected result:

image

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 6, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Apr 7, 2017

duping to #1985 and #2554 ?

@bsclifton
Copy link
Member

@luixxiul this is a little different (but related). The "Save as type" box should be set based on the file name. This change will be a Muon/electron change

@bsclifton
Copy link
Member

@jonathansampson should this be in 0.14.2? We're closing up dev on this soon and without an owner, it's at risk

@jonathansampson jonathansampson modified the milestones: 1.0.0, 0.14.2 Apr 7, 2017
@jonathansampson
Copy link
Collaborator Author

jonathansampson commented Apr 7, 2017

@bsclifton It should not. I've punted to 1.0.0. In fact, we may in fact close in favor of #1985.

@bsclifton bsclifton changed the title Incorrect value for "Save as type" Set the file type filter when presenting a save dialog Sep 8, 2017
@bsclifton bsclifton removed the upstream label Sep 8, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@darkdh darkdh self-assigned this Nov 11, 2017
@darkdh darkdh modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Jan 27, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@srirambv
Copy link
Collaborator

Verified on muon 5.1.0 built from source rev aa9db3c

@kjozwiak
Copy link
Member

kjozwiak commented Mar 22, 2018

Verified that the above issue has been fixed on macOS 10.13.3 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.