Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Instances of "GoogleChrome" only partially replaced #8181

Closed
jonathansampson opened this issue Apr 10, 2017 · 0 comments
Closed

Instances of "GoogleChrome" only partially replaced #8181

jonathansampson opened this issue Apr 10, 2017 · 0 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 10, 2017

Automated test plan

npm run unittest -- --grep="extensionsUtil bravifyText"

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    The extensionsUtil.js::bravifyText method does not cover GoogleChrome.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Use Pocket on an older version of Brave
    2. Update to 0.14.2
    3. Note presence of "GoogleBrave" in new Extensions page

From session-store-1:

"base_path": "…Extensions/niloccemoadcdkdjlinkgdfekeahmflj/2.1.17",
"version": "2.1.17",
"id": "niloccemoadcdkdjlinkgdfekeahmflj",
"description": "__MSG_extDescriptionGoogleChrome__",
  • Actual result:
    GoogleChrome is not covered by the bravifyText method, resulting in GoogleBrave appearing in the new Extensions page.

  • Expected result:
    Brave should cover the missing case.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    No.

  • Is this an issue in the currently released version?
    No.

  • Can this issue be consistently reproduced?
    Yes.

  • Screenshot if needed:
    image

  • Any related issues:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants