Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sort indicator is not shown next to the table heading in about:preferences#extensions #8197

Closed
srirambv opened this issue Apr 10, 2017 · 2 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 10, 2017

Testing Plan

#8222 (comment)

Navigate to about:preferences#extensions
Click the Enabled column header
Note that sorting has been disabled

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Sort indicator is not shown next to the table heading in about:preferences#extensions

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.14.2
    rev 61ae1a7

  • Steps to reproduce:

    1. Open about:preferences#extension
    2. Click on the table heading to sort the list
    3. Sort indicator is shown below the text which looks awkward
  • Actual result:
    Sort indicator is not shown next to the table heading in about:preferences#extensions

  • Expected result:
    Should show the sort indicator next to the table heading

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto

@srirambv srirambv added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified release/not-blocking labels Apr 10, 2017
@srirambv srirambv added this to the 0.14.3 milestone Apr 10, 2017
@cezaraugusto
Copy link
Contributor

/cc @jonathansampson that's related to convo we had on Slack, mind grabbing? just need to add sortingDisabled to sortableTable

@jonathansampson
Copy link
Collaborator

@cezaraugusto Just got back to a computer; I'll take it! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants