Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Re-attaching the tab is not easiest thing to do #8289

Closed
srirambv opened this issue Apr 13, 2017 · 6 comments
Closed

Re-attaching the tab is not easiest thing to do #8289

srirambv opened this issue Apr 13, 2017 · 6 comments
Assignees
Labels
feature/tabsbar misc/drag-and-drop polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 13, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Re-attaching the tab is not easiest thing to do

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.14.2
    rev f07c142

  • Steps to reproduce:

    1. Have a pin tab in the browser window and open multiple tabs
    2. Tear off one of the tab to create a new window
    3. Try to reattach the tab back into the original window by dragging it on to the tabs bar, need to give it couple of tries before it gets re-attached to the main window but ends up creating lot of tear off windows in the process
  • Actual result:
    Difficult to reattach the teared off tab

  • Expected result:
    Should be simple enough to reattach the tab to the main window

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    attach-detach 1

  • Any related issues: Fixed jumpy tab drag and drop #8288 when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled (follow-up of #6033) #6863
    cc: @bbondy

@srirambv srirambv added feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified labels Apr 13, 2017
@srirambv srirambv added this to the 0.14.3 milestone Apr 13, 2017
@luixxiul
Copy link
Contributor

Does this not block 0.14.3? For me this seems to be a quite annoying issue.

@srirambv
Copy link
Collaborator Author

Sorry meant to add release blocking. It is actually very annoying because tabs can tear off pretty easily if the tab drag is not properly handled.

@luixxiul
Copy link
Contributor

luixxiul commented May 8, 2017

I think the issue has been fixed and can be closed.

@bsclifton
Copy link
Member

@srirambv as the original opener of the issue, can you please re-test and close if you feel the issue has been fixed? Thanks! 😄

@srirambv
Copy link
Collaborator Author

srirambv commented May 8, 2017

Yes this is fixed. Its much easier now to tear off and attach back the tabs. Will remove the milestone as its fixed. @bsclifton does this need to be included for 0.15.3?

@srirambv srirambv closed this as completed May 8, 2017
@srirambv srirambv removed this from the 1.0.0 milestone May 8, 2017
@bsclifton
Copy link
Member

@srirambv thanks for removing milestone 😄 Only needs to be included if we wanted to share the fix in the release notes and it was a problem last release (0.15.2) and it was fixed this release (0.15.3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/tabsbar misc/drag-and-drop polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified
Projects
None yet
Development

No branches or pull requests

5 participants