Extension API: chrome.browserAction.setIcon assumes a relative path

[jonathansampson]

https://developer.chrome.com/extensions/browserAction#method-setIcon

Brave presently assumes that values coming in from chrome.browserAction.setIcon will have relative paths. (Also worth noting that Brave assumes the path is either a string, or an object with properties 19 and 38. If neither assumption is true, no icon is showed.)

extensionState.js:

if (path && basePath) {
  // Older extensions may provide a string path
  if (typeof path === 'string') {
    return `-webkit-image-set(
      url(${basePath}/${path}) 1x`
  }
  let basePath19 = path.get('19')
  let basePath38 = path.get('38')
  if (basePath19 && basePath38) {
    return `-webkit-image-set(
      url(${basePath}/${basePath19}) 1x,
      url(${basePath}/${basePath38}) 2x`
  }
}

This is not always the case. Evernote, for example, does the following:

a = "images/ext_icons/" + a;
      
var d = {
  19: chrome.extension.getURL(a + "-19x19.png"),
  20: chrome.extension.getURL(a + "-20x20.png"),
  38: chrome.extension.getURL(a + "-19x19@2x.png"),
  40: chrome.extension.getURL(a + "-40x40.png")
};

chrome.browserAction.setIcon({ path: d })

Related Issues: #8500

[jonathansampson]

Blocks #8327