Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Offer option to have URL bar fill empty space ("wide URL bar") #8421

Closed
ShalokShalom opened this issue Apr 21, 2017 · 16 comments
Closed

Offer option to have URL bar fill empty space ("wide URL bar") #8421

ShalokShalom opened this issue Apr 21, 2017 · 16 comments

Comments

@ShalokShalom
Copy link

ShalokShalom commented Apr 21, 2017

Test plan

#8714 (comment)


  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:

screenshot_20170421_144620

This here is the build log:

https://gist.github.com/ShalokShalom/86e51be92dca5ec979445c695d56f95a

@cndouglas
Copy link

@ShalokShalom Which icons are missing?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Apr 23, 2017
@ShalokShalom
Copy link
Author

See by yourself? I dont know yet, which icons should be placed there, you see the empty places in my screenshot?

@NejcZdovc
Copy link
Contributor

@ShalokShalom I don't see any icon that is missing, can you please point us in a right direction/area? Thank you

@ShalokShalom
Copy link
Author

Do you see the screenshot?

With this large, grey empty space on both sides?

@NejcZdovc
Copy link
Contributor

Yes I can see the empty space. There aren't any icons there, this is not a bug. What icons would you expect to be there?

@ShalokShalom
Copy link
Author

Ahm, for what is this space then?

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 23, 2017

URL bar is aligned to the center of the window and max width of it it's 900px. You see a white space because your screen is bigger and limit has kicked in.

@luixxiul
Copy link
Contributor

@ShalokShalom maybe you are expecting this kind of width?

clipboard01

@bsclifton
Copy link
Member

The other use for that area is so that you can easily grab and drag the window

@ShalokShalom
Copy link
Author

@luixxiul Yes

Is there a way to set this to the look and feel i am used to?

@luixxiul
Copy link
Contributor

luixxiul commented Apr 24, 2017

I would prefer having it as an option, "Use wide URL bar" or "Maximize the URL bar".

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Apr 25, 2017
@bsclifton bsclifton changed the title missing icons in toolbar Offer option to have URL bar fill empty space ("wide URL bar") Apr 26, 2017
@ShalokShalom
Copy link
Author

Thanks 👍

@luixxiul luixxiul self-assigned this May 5, 2017
@luixxiul luixxiul mentioned this issue May 5, 2017
4 tasks
@luixxiul luixxiul added this to the 0.15.3 milestone May 5, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@bradleyrichter
Copy link
Contributor

yes, default should be as is to allow for easier window dragging so please add a pref in about:preferences#advanced.

@ShalokShalom
Copy link
Author

So long as i can recompile..

@luixxiul
Copy link
Contributor

luixxiul commented May 19, 2017

@ShalokShalom the wide URL bar will be added to the browser after two updates, 0.16.100. Please wait for a moment, thanks.

@ShalokShalom
Copy link
Author

Thanks a lot ^-^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.