Focus switches to pinned tab when a tab is closed

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Focus switches to pinned tab when a tab is closed

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 7 ia32

• Brave Version (revision SHA):
  Brave 0.15.1
  rev 0598ddf

• Steps to reproduce:

  1. Clean install 0.15.0
  2. Pin a site and open 4-5 new tabs / visit sites in them
  3. Upgrade to 0.15.1 while the browser window is opened
  4. Wait for the browser to close and upgrade and relaunch
  5. Ensure the tabs are still available after upgrade
  6. Close one of the tabs, focus doesn't switch to the parent tab(default setting), instead focus goes to the pinned tab

• Actual result:
  Focus switches to pinned tab when a tab is closed

• Expected result:
  Focus should be based on the selection done in about:preferences#tabs

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes, Was able to reproduce in 0.15.0 upgrade from RC5 to RC6

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:

  1. After upgrade focus on any of the normal tabs
  2. Close the tab, focus is on pinned tabs

• Screenshot if needed:

• Any related issues:

[bsclifton]

May be fixed by #8580; @srirambv can you recheck with 0.15.2 preview 2 (or master)

[srirambv]

This is still an issue on 0.15.2 preview 2 when the browser is relaunched closing any tab switches it to the last pinned tab.

[bsclifton]

Moving to 0.15.3xx since this is a regression from the 0.15.2 that was released (0.15.2 mentioned above ended up turning into 0.15.3xx)

[bbondy]

@bridiver did you fix this already?

[alexwykoff]

@srirambv let's retest this after the latest builds

[bsclifton]

Looks good to me 😄 Fixed with #8863