Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave quits when New Tab command issued without window #8575

Closed
lukemulks opened this issue Apr 29, 2017 · 4 comments
Closed

Brave quits when New Tab command issued without window #8575

lukemulks opened this issue Apr 29, 2017 · 4 comments

Comments

@lukemulks
Copy link
Collaborator

lukemulks commented Apr 29, 2017

Test Plan

  1. Launch Brave on macOS and close all open windows
  2. From the File menu, pick New Tab and confirm new window is created w/ new tab
  3. Close the window
  4. From the File menu, pick New Private Tab and confirm new window is created w/ new private tab
  5. Close the window
  6. From the File menu, pick New Session Tab > New Session Tab 5 and confirm new window is created w/ session tab
  7. With a window open, pick the options specified in 2, 4, and 6 and make sure they still work as expected

Original issue description

A Brave Community contributor reported the following Issue:

Brave quits when New Tab command issued without window

Brave Community thread:
https://community.brave.com/t/brave-quits-when-new-tab-command-issued-without-window/2509

Details below have been extracted from the Community thread

Browser Profile

macOS 10.12.4 
Macbook Pro
Brave v0.15.0 
rev 71fb730

Steps to Repro:

  • Open Brave
  • Close all open tabs.
  • Brave should still be open (in macOS, you'll see the "Brave" application menu) but there are no windows (confirm in the Window menu).
  • Go to File > New Tab, or in macOS, type Cmd-T.
  • Brave quits.

Potentially related to:
This may be related to another unexpected behavior:

  • Open Location command (macOS = Cmd-L) when there is no open window.
  • If there are no open windows and I type Cmd-L, I expect Brave to create a window and give focus to the location bar.
  • But it does nothing.
  • It was after this failed that I tried Cmd-T and found the bug.

Expected Behavior
Both New Tab and Open Location should create a new window if no window exists at the moment.

@lukemulks lukemulks added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. OS/macOS labels Apr 29, 2017
@rucksack-texnology
Copy link

Not just a laptop issue. Same misbehavior occurs on iMac running same version of macOS (10.12.4) and same version of Brave (0.15.0).

@bsclifton bsclifton added crash and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels May 3, 2017
@bsclifton
Copy link
Member

Confirmed

@bsclifton bsclifton modified the milestones: 0.15.3, 0.15.2 May 3, 2017
@bsclifton
Copy link
Member

Moving to 0.15.2; if we don't have time, we can push back. But wanted to tentatively pull in since it does cause a crash

@bsclifton
Copy link
Member

2017-05-06 00:19:52.876 Brave Helper[5875:1106224] Couldn't set selectedTextBackgroundColor from default ()
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property 'id' of null
    at getCurrentWindowId (/Users/clifton/Documents/browser-laptop/app/common/commonMenu.js:33:43)
    at click (/Users/clifton/Documents/browser-laptop/app/common/commonMenu.js:78:19)
    at MenuItem.click (/Users/clifton/Documents/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/menu-item.js:59:9)
    at Function.executeCommand (/Users/clifton/Documents/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/menu.js:121:15)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.