You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Sync alert needs refactoring. While testing Refactor syncTab.js with Aphrodite #8044 found sync reset alert code buttons were not aligned properly. Needs refactoring to match existing behavior
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA): b098619@luixxiul confirmed same on master branch as well
Steps to reproduce:
Enable sync on laptop
Click on reset Sync, cancel -> close modal
Click on reset sync again -> alert box buttons aligned next to text
The suppress message and the button is aligned to the same line on this issue: #7930
The fix works fine only if there is one button, which is "OK" button. With other buttons it does not work as expected, as the screenshot on the 1st post shows.
The block for buttons and the other stuff should be separated to avoid such a case, which is a strategy I took when I refactored commonForm components (See: commonFormButtonWrapper on about:styles )
Test plan
#8622 (comment)
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Sync alert needs refactoring. While testing Refactor syncTab.js with Aphrodite #8044 found sync reset alert code buttons were not aligned properly. Needs refactoring to match existing behavior
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
b098619 @luixxiul confirmed same on master branch as well
Steps to reproduce:
-- Screenshot if needed:
The text was updated successfully, but these errors were encountered: