Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Error message in pinned tab will not be in the same tab #8639

Closed
darkdh opened this issue May 2, 2017 · 1 comment
Closed

Error message in pinned tab will not be in the same tab #8639

darkdh opened this issue May 2, 2017 · 1 comment
Assignees
@petemill
Labels
feature/pinned-tabs priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale

Comments

@darkdh
Copy link
Member

darkdh commented May 2, 2017 •
edited by bbondy
Loading

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    There will be a new tab showing error message for pinned tab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.15.2 Preview 2

  • Steps to reproduce:

    1. Pin badssl.com
    2. Click on "expired" or other red examples

  • Actual result:
    There will be a new tab of error page

  • Expected result:
    Error page should be in a same pinned tab

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
@darkdh darkdh added this to the 0.15.2 milestone May 2, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@bsclifton
Copy link
Member

Per @darkdh, this still happens in 0.17.15

@bbondy bbondy removed this from the 0.18.x (Beta Channel) milestone Jul 11, 2017
@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed impact/low labels Nov 22, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
This was referenced Mar 26, 2018
Closed
Closed
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Completed work Mar 28, 2018
@alexwykoff alexwykoff modified the milestones: Completed work, 0.25.x Apr 10, 2018
@bsclifton bsclifton added the stale label Sep 3, 2018
@bsclifton bsclifton removed this from the 0.25.x (Nightly Channel) milestone Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
feature/pinned-tabs priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show intermediate errors in pinned tabs petemill/browser-laptop
6 participants
@petemill @bbondy @alexwykoff @luixxiul @bsclifton @darkdh