Another context menu appears after displaying an context menu on new tab button

[luixxiul]

Test plan

Right click on new tab button should work as expected; only showing one menu

Original issue description

Describe the issue you encountered: Another context menu appears after displaying an context menu on new tab button

• Platform (Win7, 8, 10? macOS? Linux distro?): debian

• Brave Version (revision SHA): 0.15.2 preview 2

• Steps to reproduce:

  1. Right click on the new tab button
  2. Left click on the existing tab (or anywhere elese)

• Actual result:
  

• Expected result: the 2nd context menu should not appear

• Extra QA steps:
  1.
  2.
  3.

• Any related issues: New Tab context menu is retained even after clicking one new tab button #6700 Useful context menu that includes "Reopen Last Closed Tab" should be available across entire tab bar #8303

[cndouglas]

Also reproducible with Brave 0.15.2 preview 2 and the latest master (8745bd5) on macOS 10.12.x.

Introduced when the menu was made native (PR #8397). There's already a e.stopPropagation() in longPressButton.js, so I'm not sure what's causing this behavior.

[bsclifton]

@luixxiul great find! 😄

@liunkae I believe this is related to #8320

Once the native menu shows, we should stop propagation. Do you think you can check it out? 😄

[srirambv]

Not reproducible on Windows 10 x64 preview 2 build.

[srirambv]

@bsclifton @luixxiul Isn't it correct it showing the tab context menu when it is clicked on it irrespective of the newtab context menu being shown when clicked on new tab?