Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

The Linux/Gtk File Uploader Dialog does not show any image preview on the side. #8854

Closed
9898287 opened this issue May 12, 2017 · 3 comments · Fixed by #11906
Closed

The Linux/Gtk File Uploader Dialog does not show any image preview on the side. #8854

9898287 opened this issue May 12, 2017 · 3 comments · Fixed by #11906
Assignees
@darkdh
Labels
OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/include upstream
Milestone
0.22.x (Release C...

Comments

@9898287
Copy link

9898287 commented May 12, 2017 •
edited by luixxiul
Loading

Test plan

#11906 (comment)

Platform and version:

Linux (Gtk) - Xubuntu 16.04
Brave: 0.15.2
rev: af7ef42
Muon: 2.58.9
libchromiumcontent: 58.0.3029.96
V8: 5.8.283.37
Node.js: 7.9.0
Update Channel: dev
os.platform: linux
os.release: 4.8.0-49-generic
os.arch: x64

  • Steps to reproduce:
1. Open any image sharing site, upload image/picture
2. The file chooser dialog pops up; however unlike firefox/chromium, the side preview is not visible

Chromium currently uses gtk2, however it has side preview too.
problem
@bsclifton
Copy link
Member

I believe this would be a change to Muon.

If electron now supports this functionality, we can look at pulling in patches to resolve this 😄

@bsclifton bsclifton mentioned this issue Nov 11, 2017
Closed
@darkdh darkdh self-assigned this Nov 11, 2017
@darkdh darkdh mentioned this issue Nov 11, 2017
Merged
8 tasks
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@darkdh darkdh modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Jan 27, 2018
@srirambv srirambv mentioned this issue Feb 20, 2018
Closed
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@srirambv srirambv mentioned this issue Mar 2, 2018
Closed
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@kjozwiak kjozwiak mentioned this issue Mar 22, 2018
Closed
@btlechowski
Copy link
Contributor

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/include upstream
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

New electron dialog changes brave/browser-laptop
6 participants
@luixxiul @bsclifton @darkdh @9898287 @LaurenWags @btlechowski