Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:brave shows win32 for all Windows platforms (even x64) #8933

Closed
bsclifton opened this issue May 18, 2017 · 1 comment
Closed

about:brave shows win32 for all Windows platforms (even x64) #8933

bsclifton opened this issue May 18, 2017 · 1 comment

Comments

@bsclifton
Copy link
Member

If you look at about:brave on 64 bit Windows, you'll notice it reports win32 as the platform. This value is coming from node.js
screen shot 2017-05-18 at 9 31 28 am

This is confusing because it looks like something is 32 bit, even though we are clearly running the 64 bit version of the software and Windows is 64 bit.

The solution would be to do a string replacement. When win32 is returned, we can substitute in a string like "Microsoft Windows". We could put this logic into the platformUtil module and update the part of the code which currently updates the values on about:brave:

['os.platform', require('os').platform],

@bbondy
Copy link
Member

bbondy commented Jul 21, 2017

Confusingly enough most people still refer even to the 64-bit Windows API as Win32 API. Microsoft started calling it Windows API (WinAPI) though but most people still call it win32 independent of arch. That being said friendlier names sound good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants