You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
This is confusing because it looks like something is 32 bit, even though we are clearly running the 64 bit version of the software and Windows is 64 bit.
The solution would be to do a string replacement. When win32 is returned, we can substitute in a string like "Microsoft Windows". We could put this logic into the platformUtil module and update the part of the code which currently updates the values on about:brave:
Confusingly enough most people still refer even to the 64-bit Windows API as Win32 API. Microsoft started calling it Windows API (WinAPI) though but most people still call it win32 independent of arch. That being said friendlier names sound good.
If you look at about:brave on 64 bit Windows, you'll notice it reports
win32
as the platform. This value is coming from node.jsThis is confusing because it looks like something is 32 bit, even though we are clearly running the 64 bit version of the software and Windows is 64 bit.
The solution would be to do a string replacement. When
win32
is returned, we can substitute in a string like "Microsoft Windows". We could put this logic into the platformUtil module and update the part of the code which currently updates the values on about:brave:browser-laptop/app/sessionStore.js
Line 417 in 7452b7e
The text was updated successfully, but these errors were encountered: