Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab opened via navigation buttons is not rendered correctly #9021

Closed
luixxiul opened this issue May 24, 2017 · 22 comments
Closed

tab opened via navigation buttons is not rendered correctly #9021

luixxiul opened this issue May 24, 2017 · 22 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 24, 2017

Describe the issue you encountered: tab opened via navigation buttons is not rendered correctly.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Tested on Debian

  • Brave Version (revision SHA): 0.15.307 / the issue cannot be reproduced on 0.15.2

  • Steps to reproduce:

    1. Open a new tab
    2. Open https://brave.com
    3. Clone the tab via the back button on the navigation bar
    4. Select the cloned tab
    5. Click the forward button on the navigation bar
  • Actual result: https://brave.com is not renderered correctly

  • Is this an issue in the currently released version?
    No. I cannot reproduce the issue on 0.15.2

  • Can this issue be consistently reproduced?
    Yes. I tested on other sites and saw the same issue.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.15.300 milestone May 24, 2017
@srirambv
Copy link
Collaborator

Confirmed on Windows x64 as well

@bsclifton
Copy link
Member

I cannot reproduce... @luixxiul @srirambv do you have another instance of Brave open?

@bridiver
Copy link
Collaborator

@luixxiul is it possible to have a visible start/stop in these videos? When they just run continuously it's really hard to see what is going on sometimes

@luixxiul
Copy link
Contributor Author

actually I can reproduce the error on ba198fd on macOS too..

@bridiver I'm taking the one-time gif, will upload very soon.

@luixxiul
Copy link
Contributor Author

brave

@luixxiul
Copy link
Contributor Author

@bridiver please open the gif ^ in a new tab and reload the tab to replay the gif, thanks.

@srirambv
Copy link
Collaborator

The issue happens only when you clone to the new tab with just one tab history. Following the same STR on existing tab history between page navigation loads the page properly

@luixxiul
Copy link
Contributor Author

luixxiul commented May 24, 2017

ok narrowing it down

  1. clear your profile / logout from github
  2. Open a new tab
  3. On the tab, open https://github.com
  4. Click "Features" from the menu
  5. Clone the tab
  6. On the cloned tab, go back to the new tab
  7. Go forward
  8. https://github.com is no longer correctly rendered
  9. Go forward
  10. https://github.com/features is no longer correctly rendered as well

@luixxiul
Copy link
Contributor Author

Also, on the broken pages, reload button does not seem to work. Neither do the zoom buttons in the kabob menu.

"Home" in History menu does work.

@bsclifton
Copy link
Member

@luixxiul @alexwykoff @srirambv do you all consider this a blocker?

@alexwykoff
Copy link
Contributor

Per https://github.com/brave/browser-laptop/wiki/(WIP)-Triage-of-issues, I would rate this Low Priority. Cloning is a rare operation.

Also, I'm DNR on 0.15.307. Finally, it hasn't been established whether or not reloading the page fixes the issue. If reloading the page fixes the issue, the impact is negligible. Unsightly at first, but it's not destroying data.

@luixxiul
Copy link
Contributor Author

luixxiul commented May 25, 2017

I don't think this is a blocker, nor low priority, however rare it seems to be reproduced by users. Just a normal bug.

If reloading the page fixes the issue

No, the reload button does not work on the broken tab. ^^^

@luixxiul
Copy link
Contributor Author

We just do not need to decide priority hasty, especially of issues reproduced on multiple platforms.

@bridiver
Copy link
Collaborator

I already have fixes for both issue

@luixxiul
Copy link
Contributor Author

@bridiver Sweet!!

@alexwykoff
Copy link
Contributor

@luixxiul we also don't want to confuse a bias due to the availability heuristic to real signal.

do any people clone tabs? yes
do many people clone tabs? no

thus low priority

@luixxiul luixxiul removed this from the 0.15.300 milestone May 25, 2017
@luixxiul
Copy link
Contributor Author

the reason I didn't think this was not a low priority issue is that the recent regressions around the navigation/tabs are I felt related or connected in some way. I'm not familiar with the code so I cannot confirm that, but that's the reasoning.

@bbondy
Copy link
Member

bbondy commented May 25, 2017

@bridiver do you have a fix for this?
I think this is actually pretty common to clone via back button to fork nav.
At least I do it all the time.

@bbondy bbondy added this to the 0.15.300 milestone May 25, 2017
@bridiver
Copy link
Collaborator

sorry, I got this issue mixed up with #8974

@bsclifton
Copy link
Member

Moving to the next release (post c59). Please pull back if we need it sooner
cc: @bbondy

@bsclifton bsclifton modified the milestones: 0.16.100, 0.15.300 May 25, 2017
@bsclifton bsclifton removed this from the 0.17.x (Frozen, only critical adds from here) milestone Jun 12, 2017
@bsclifton
Copy link
Member

Closing as this appears to have been fixed. I can't repro anymore (using 0.16.9). Please re-open if we see it again

@luixxiul
Copy link
Contributor Author

I still see the same issue on macOS.

Brave 0.19.0 91465de
Muon 4.0.3

Also devtool cannot be opened via context menu. Opening it via the menu bar, I get this log:

Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Reg-webfont.woff' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

brave.com/:1 Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Reg-webfont.ttf' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

brave.com/:1 Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Sbold-webfont.woff' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

brave.com/:1 Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Sbold-webfont.ttf' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

brave.com/:1 Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Bold-webfont.woff' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

brave.com/:1 Refused to load the font 'chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/app/fonts/ProximaNova-Bold-webfont.ttf' because it violates the following Content Security Policy directive: "font-src https://fonts.gstatic.com data: 'self'".

/assets/plugins/font-awesome/css/font-awesome.min.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/css/custom.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/plugins/bootstrap/css/bootstrap.min.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/css/one.style.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/css/footers/footer-v5.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/css/footers/footer-v1.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/plugins/animate.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
/assets/plugins/line-icons/line-icons.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
piwik.js Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

screenshot 2017-06-13 12 19 50

Let me reopen in case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants