Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Control+W does not work after closing about:preferences #9065

Closed
luixxiul opened this issue May 26, 2017 · 5 comments
Closed

Control+W does not work after closing about:preferences #9065

luixxiul opened this issue May 26, 2017 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 26, 2017

Describe the issue you encountered: Control+W does not work after closing about:preferences. This is a follow-up to #8974

  1. Open about:preferences#tabs
  2. Change "When closing an active tab" setting to Select the last viewed tab
  3. Open a new tab
  4. Visit https://github.com on the tab
  5. Click 'Features' on the menu
  6. Click Go back button two times with the middle mouse button on the navigation bar
  7. Select the last tab
  8. Control + W
  9. Repeat ^ until about:preferences#tabs is closed

Actual result: A blank github.com tab is left, which cannot be closed with Control + W

Expected result: the tab should be rendered and be able to be closed with the shortcut keys.


@luixxiul
Copy link
Contributor Author

By opening a new tab, the blank tab gets rendered fine.

@cndouglas
Copy link

Possibly related: #9083.

@alexwykoff
Copy link
Contributor

@srirambv & @luixxiul can you repro on 0.17.x?

@luixxiul
Copy link
Contributor Author

no it seems the issue has been fixed. it selects correctly the last viewed tab, which is not the tab opened first with the middle mouse button.

@luixxiul
Copy link
Contributor Author

I'm wondering which PR has fixed the issue - @bsclifton do you have an idea?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants