Brave Fails to "Remember this decision"

[jonathansampson]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Brave fails to remember this decision when denying the use of flash on a page. Each visit to that same page will prompt the user again to allow or deny flash. Clicking the remember this decision label appears to have no effect.

Platform (Win7, 8, 10? macOS? Linux distro?):
Desktop

Brave Version (revision SHA):
fc4b892

Steps to reproduce:

1. Navigate to https://get.adobe.com/flashplayer/about/
2. Select Remember this decision and Deny
3. Refresh the page

Actual result:
User is prompted again to Allow or Deny flash.

Expected result:
Brave remembers to Deny flash.

Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes

Is this an issue in the currently released version?
Yes

Can this issue be consistently reproduced?
Yes

[diracdeltas]

This was already fixed by #8828 i think. It's marked for the 0.17.x milestone but feel free to move it.

[alexwykoff]

While this appears to work for the adobe site, it doesn't work for homestarrunner.com.
2017-07-27 08-49-40.mp4.zip