Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Polish compact bravery panel #9077

Closed
luixxiul opened this issue May 26, 2017 · 5 comments
Closed

Polish compact bravery panel #9077

luixxiul opened this issue May 26, 2017 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 26, 2017

Test plan:

#9078 (comment)


Describe the issue you encountered: Polish compact bravery panel based on @bradleyrichter 's spec on #9016 (comment).

image

  • I added a close button as I have witnessed some user delay for initial closing.
  • I rearranged the top area to make room for the long URL
  • I adjusted the number area to allow for 1 or 2 numbers. I think this will look cleanest and not matter if digits are updating when the panel is open.
@luixxiul luixxiul added feature/shields polish Nice to have — usually related to front-end/visual tasks. labels May 26, 2017
@luixxiul luixxiul added this to the 0.16.200 milestone May 26, 2017
@luixxiul luixxiul self-assigned this May 26, 2017
@luixxiul
Copy link
Contributor Author

I think this would satisfy @bradleyrichter:

screenshot 2017-05-27 2 13 08

With a screen ruler:

screenshot 2017-05-27 2 14 08

@bradleyrichter
Copy link
Contributor

woah...the only way I could tell it was not a mockup was the switch order. Amazing job @luixxiul !

@luixxiul luixxiul modified the milestones: 0.16.100 (Frozen, only critical adds from here), 0.16.200 May 27, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.18.x, 0.17.x (Frozen, only critical adds from here) Jun 7, 2017
@cezaraugusto
Copy link
Contributor

moving to 0.18.x, pls see #9078 (comment)

@bsclifton bsclifton modified the milestones: 0.17.x (Frozen, only critical adds from here), 0.18.x Jun 7, 2017
@bsclifton
Copy link
Member

moving back to 0.17.x after merge issue was fixed 😄 👍

@alexwykoff
Copy link
Contributor

Polish tasks shouldn't be included in release notes in general.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants