Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned tab shows blank white page when relaunching the browser #9134

Closed
srirambv opened this issue May 30, 2017 · 7 comments
Closed

Pinned tab shows blank white page when relaunching the browser #9134

srirambv opened this issue May 30, 2017 · 7 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 30, 2017

Test plan

#9219 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Pinned tab shows blank white page when relaunching the browser. It is exactly Pinned tab shows blank white page when relaunching the browser #8873

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.16.0
    rev be76cd3
    Muon 3.2.101

  • Steps to reproduce:

    1. Have a few pinned tabs
    2. Set focus to the last pinned tab and close the browser
    3. Wait for a while before relaunching the browser (important step)
    4. After relaunch, the last pinned tab is white blank page
    5. Hover over the last tab reveals the page content, Only after clicking the page it shows the page content correctly
  • Actual result:
    Pinned tab shows blank white page when relaunching the browser

  • Expected result:
    All tabs should be loaded properly and page content should be shown correctly

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Found on previous build but closed as it might have been fixed by Improves tab switching and tab related perf #8863

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Pinned tab shows blank white page when relaunching the browser #8873
    cc: @bridiver

@srirambv srirambv added this to the 0.16.0 milestone May 30, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.311, 0.16.0 May 30, 2017
@bsclifton
Copy link
Member

appears to be 0.16.0 specific; unable to repro on 0.15.310. Moving back to 0.16.0

@bsclifton bsclifton modified the milestones: 0.16.0 (Frozen, only critical adds from here), 0.15.311 (Frozen, only critical adds from here) May 30, 2017
@bridiver
Copy link
Collaborator

bridiver commented Jun 2, 2017

Step 3 seems very odd to me. Absolutely nothing happens between the time that the browser shuts down and the time that it starts back up again. If there is a timing issue after shutdown the problem may be related to shutdown not completing in a normal time

@bridiver
Copy link
Collaborator

bridiver commented Jun 2, 2017

I see a completely different issue in master which is that it reopens with the first normal tab active instead of the pinned tab

@bridiver
Copy link
Collaborator

bridiver commented Jun 2, 2017

didn't notice it was windows only, but mac also has the wrong behavior. Not sure why they would be different

@bsclifton
Copy link
Member

Will be ready to retest with the next build. Stay tuned...

@bbondy
Copy link
Member

bbondy commented Jun 6, 2017

I think this is fixed, please re-open if it doesn't pass.

@bbondy bbondy closed this as completed Jun 6, 2017
@bsclifton
Copy link
Member

Confirmed fixed on Windows 10 x64 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.