-
Notifications
You must be signed in to change notification settings - Fork 974
beef up the kabab #9305
Comments
@bradleyrichter how about this? It makes the entire 26x26 box clickable in the same way as it is for newTabButton. |
@luixxiul I didn't see a change in with those numbers but I created a new SVG and added some padding to align it under the lion button on macOS but it should work fine on Windows. |
@luixxiul I think you got the point, mind taking this one? I would make this the same width as bravery icon and apply flex to middlefy it so both can be forever aligned vertically. Also adding extra space will improve a11y. If turns out extra space makes clicking area too big, we could replace extra-padding with extra-margin. SVG will take care of the bad looking image issue. Pls ping me if you can't make for some reason and I'll jump in. |
@cezaraugusto OK please, thanks. |
I noticed this on Master and I really don´t like how it looks 👎 Sorry 🙁 |
Hi @cezaraugusto @luixxiul I have to agree with @Jacalz, I understand this is now a closed issue but it just looks so similar to Chrome's and other types of browsers that try to indicate that, this is hiding something behind it; can't you guys mimic it to look like a lions claw/s in forward slash angle "/" (excuse the tautology) I suppose if you also had it slanted, you could maximize the usage of the tab area and use up the top-right edge of the bar, possibly enough to include another tab without an extra tab set for some users depending on their monitor, essentially saving half a millimeter if you go right to the edge. Furthermore, there's only few issues left to close before the next major release of 0.19.x and I think if you did consider it you'd push into backlogs so I think if you do contemplate this design it's best to do so now than later. (No point for the paste if it's not considered) Could someone paste an image of what of the following keys multiplied would look like slanted from the top obviously , ' ` (first one is a comma which I think looks more like a lions claw but at a different angle, second one's an apostrophe and the third one is the key left of "1" on a ThinkPad) |
Test plan
#9363 (comment)
We have received comments that the kabob is too small/soft and hard to notice.
This will add some weight to it while retaining it's kababness by updating the SVG file.
preview:
new SVG:
menu_btn.svg.zip
margin adjustment:
The text was updated successfully, but these errors were encountered: