Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

beef up the kabab #9305

Closed
bradleyrichter opened this issue Jun 7, 2017 · 7 comments
Closed

beef up the kabab #9305

bradleyrichter opened this issue Jun 7, 2017 · 7 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 7, 2017

Test plan

#9363 (comment)


We have received comments that the kabob is too small/soft and hard to notice.

This will add some weight to it while retaining it's kababness by updating the SVG file.

preview:
image

new SVG:
image

menu_btn.svg.zip

margin adjustment:
image

@bradleyrichter bradleyrichter added the design A design change, especially one which needs input from the design team. label Jun 7, 2017
@bradleyrichter bradleyrichter added this to the 0.17.x (Frozen, only critical adds from here) milestone Jun 7, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 7, 2017

@bradleyrichter how about this? It makes the entire 26x26 box clickable in the same way as it is for newTabButton.

clipboard01

@bradleyrichter
Copy link
Contributor Author

@luixxiul I didn't see a change in with those numbers but I created a new SVG and added some padding to align it under the lion button on macOS but it should work fine on Windows.

@luixxiul
Copy link
Contributor

luixxiul commented Jun 7, 2017

I see. On Windows the picture on the 1st post it looks for me it is blurred like triple ~ aligned vertically. Maybe that is my eye problem.

clipboard01

With the SVG file that should not happen though.

@NejcZdovc NejcZdovc removed their assignment Jun 7, 2017
@cezaraugusto
Copy link
Contributor

@luixxiul I think you got the point, mind taking this one?

I would make this the same width as bravery icon and apply flex to middlefy it so both can be forever aligned vertically. Also adding extra space will improve a11y. If turns out extra space makes clicking area too big, we could replace extra-padding with extra-margin. SVG will take care of the bad looking image issue.

Pls ping me if you can't make for some reason and I'll jump in.

@luixxiul
Copy link
Contributor

luixxiul commented Jun 8, 2017

@cezaraugusto OK please, thanks.

@cezaraugusto cezaraugusto removed their assignment Jun 8, 2017
@luixxiul luixxiul mentioned this issue Jun 9, 2017
8 tasks
@alexwykoff alexwykoff modified the milestones: 0.19.x, 0.17.x (Frozen, only critical adds from here) Jun 12, 2017
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
@Jacalz
Copy link
Contributor

Jacalz commented Jul 7, 2017

I noticed this on Master and I really don´t like how it looks 👎 Sorry 🙁
The thing is that it should be wider, it just looks like the old menu was stangely stretched 😅

@NumDeP
Copy link

NumDeP commented Sep 16, 2017

Hi @cezaraugusto @luixxiul I have to agree with @Jacalz, I understand this is now a closed issue but it just looks so similar to Chrome's and other types of browsers that try to indicate that, this is hiding something behind it; can't you guys mimic it to look like a lions claw/s in forward slash angle "/" (excuse the tautology)

I suppose if you also had it slanted, you could maximize the usage of the tab area and use up the top-right edge of the bar, possibly enough to include another tab without an extra tab set for some users depending on their monitor, essentially saving half a millimeter if you go right to the edge.

Furthermore, there's only few issues left to close before the next major release of 0.19.x and I think if you did consider it you'd push into backlogs so I think if you do contemplate this design it's best to do so now than later.

(No point for the paste if it's not considered) Could someone paste an image of what of the following keys multiplied would look like slanted from the top obviously , ' ` (first one is a comma which I think looks more like a lions claw but at a different angle, second one's an apostrophe and the third one is the key left of "1" on a ThinkPad)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants