Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Individual bookmarks not synced from laptop after Payments are switched off #9684

Closed
LaurenWags opened this issue Jun 23, 2017 · 4 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 23, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Toggling Payments on --> off appears to break sync.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    Brave 0.17.7
    rev 21cf3d1
    Muon 4.1.3

  • Steps to reproduce (two ways)
    One

    1. Switch payments on in Preferences. (I waited until my wallet was created)
    2. Switch payments off in Preferences.
    3. Set up folders and bookmarks on laptop.
    4. Set up folders and bookmarks on another device (I used Android and iOS).
    5. Set up sync group on laptop.
    6. Open sync background page. chrome-extension://cjnmeadmgmiihncdidmfiabhenbggfjm/_generated_background_page.html
    7. Join sync group on Android and iOS. All devices are synced as expected.
    8. I did an import, this also synced as expected.
    9. Add a bookmark on laptop to bookmarks bar.
    10. This bookmark does not get synced.

Two:

  1. Sync devices (ex. laptop and Android)
  2. Perform simple sync test (add bookmark to bookmarks bar on laptop), sync is working as expected.
  3. Switch on payments.
  4. Add bookmark to bookmarks bar on laptop. Sync is working as expected.
  5. Turn off payments.
  6. Again, add bookmark to bookmarks bar on laptop. This bookmark will not be synced.
  • Actual result:
    Bookmark added to bookmarks bar is not synced.

  • Expected result:
    Bookmark should be synced.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Add bookmark on Android. Bookmark is synced to laptop and iOS.
    2. Add bookmark on iOS. Bookmark is synced to laptop and Android.
  • Screenshot if needed:
    Covers steps 8 and 9 from the first scenario (it's a long recording)-
    111_01

  • Any related issues:

@LaurenWags
Copy link
Member Author

LaurenWags commented Jun 23, 2017

Originally reported under brave/sync#121

@alexwykoff
Copy link
Contributor

I couldn't replicate this 0.17.7

@Jacalz
Copy link
Contributor

Jacalz commented Jun 25, 2017

Can not repro on 0.17.9 with 17.06.21.14 on iOS, maby this should be moved to Android?

@alexwykoff alexwykoff modified the milestones: 0.18.x (Developer Channel), 0.17.x (Beta Channel) Jun 27, 2017
@alexwykoff alexwykoff added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. and removed release/blocking labels Jun 27, 2017
@bbondy
Copy link
Member

bbondy commented Jul 11, 2017

Please re-open if you see this problem again.

@alexwykoff alexwykoff modified the milestones: 0.20.x (Nightly Channel), 0.18.x (Beta Channel), 0.18.x hotfix Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.