Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar text not selected when in titlemode + F6 keyboard shortcut used #9764

Closed
bsclifton opened this issue Jun 28, 2017 · 6 comments
Closed
Labels

Comments

@bsclifton
Copy link
Member

bsclifton commented Jun 28, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    While testing reliably activate titleMode based on mouse state #9411, I noticed that when the magic titlebar is enabled (ex: always show URL bar is disabled), the text in the URL bar is not selected when bar is focused via keyboard. If the mouse is in the top area (and URL bar is shown), the keyboard shortcuts work as expected

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    HEAD on master

  • Steps to reproduce:

    1. In Preferences > Advanced, make sure Always show the URL bar is disabled
    2. Load https://brave.com
    3. Move your mouse to the content area of the screen (ex: not the URL bar or titlebar area) and confirm title mode is shown
    4. Press F6 (cmd+L / ctrl+L do work, this issue is only present when using the F6 keyboard shortcut) which should show and focus the URL bar
      (new notes - as of 0.18.x releases)
    5. The URL bar may focus correctly. If so, click back onto the webpage (brave.com) and select some text
    6. Press F6 again which should show and focus the URL bar
  • Actual result:
    The text is not highlighted (ex: you can't type to replace it)

  • Expected result:
    The text should be highlighted. You can get a feel for this by pushing F6 twice

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Possibly related (ex: may possibly fix):
    cmd + l appears to be dropping input on urlbar #7358

cc: @cezaraugusto

@cezaraugusto
Copy link
Contributor

@bsclifton can you confirm if still an issue? can't repro in 0.18.19

@luixxiul luixxiul added bug needs-info Another team member needs information from the PR/issue opener. labels Aug 9, 2017
@bsclifton
Copy link
Member Author

@cezaraugusto yes- I can still repro ☹️ I updated the steps. Can you confirm you get the same behavior?

@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 22, 2017
@ghost
Copy link

ghost commented Sep 11, 2017

I'm not able to reproduce this or #7358. @bsclifton can you please confirm this is still an issue. (again, sorry)

@bsclifton
Copy link
Member Author

works every time for me with Cmd + L- however, F6 does not seem to work as expected

@ghost
Copy link

ghost commented Sep 11, 2017

Updated description after honing in on this being reproducible only with F6 shortcut and not cmd+L.

@ghost ghost added impact/low and removed needs-info Another team member needs information from the PR/issue opener. labels Sep 11, 2017
@bsclifton bsclifton changed the title URL bar text not selected when in titlemode + keyboard shortcut used (F6, cmd/ctrl + L) URL bar text not selected when in titlemode + F6 keyboard shortcut used Sep 12, 2017
@cezaraugusto
Copy link
Contributor

self notes: typing document.activeElement.nodeName to check who's in focus shows that once you select the text and hit F6 focus is persisted in 'WEBVIEW'.

@bsclifton bsclifton added priority/P4 Minor loss of function. Workaround usually present. and removed impact/low labels Oct 9, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Sep 18, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants