Ecosia icon not shown in 0.17.x

[Jacalz]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  The Ecosia icon is not shown

• Platform (Win7, 8, 10? macOS? Linux distro?):
  MacOS 10.12.5 and Windows 10

• Brave Version (revision SHA):
  0.17.13

• Steps to reproduce:

  1. Open about:preferences#search
  2. Look at Ecosia

• Actual result:
  Icon not shown

• Expected result:
  Icon should show

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  
  

• Any related issues:

[luixxiul]

Nice catch @Jacalz!

the favicon address has been moved to https://cdn.ecosia.org/assets/images/ico/favicon.ico

[Jacalz]

The thing is that it is only a problem in 0.17.x because that branch was created before #9291 was merged to master 😉 This only needs to be merged into 0.17.x 🤗

[Jacalz]

Closed by 4944c2c