Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add groupedItem to BrowserButton on noScriptInfo.js #9981

Closed
luixxiul opened this issue Jul 12, 2017 · 0 comments
Closed

Add groupedItem to BrowserButton on noScriptInfo.js #9981

luixxiul opened this issue Jul 12, 2017 · 0 comments
Assignees
@luixxiul
Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 12, 2017 •
edited
Loading

Test plan

#9982 (comment)

Describe the issue you encountered: Add groupedItem to BrowserButton on noScriptInfo.js

  • Brave Version (revision SHA): master

  • Steps to reproduce:

    1. Open twitter.com
    2. Block Scripts
    3. Click the NoScript button on the URL bar

  • Actual result: There is a margin between the buttons, which is inconsistent

  • Expected result: The margin should be consistent

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: Refactor forms.less with Aphrodite #7989
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
3 participants
@luixxiul @srirambv @LaurenWags