Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix activateIfOpen #9965

Merged
merged 1 commit into from
Jul 18, 2017
Merged

fix activateIfOpen #9965

merged 1 commit into from
Jul 18, 2017

Conversation

bridiver
Copy link
Collaborator

fix #9964

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added the bug label Jul 11, 2017
@bridiver bridiver added this to the 0.18.x (Beta Channel) milestone Jul 11, 2017
@bridiver bridiver self-assigned this Jul 11, 2017
@bridiver bridiver requested review from bbondy and cezaraugusto July 11, 2017 20:42
@bbondy bbondy modified the milestones: 0.19.x (Developer Channel), 0.18.x (Beta Channel) Jul 12, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bridiver bridiver merged commit 3b5de18 into master Jul 18, 2017
@bsclifton bsclifton deleted the issue-9964 branch July 19, 2017 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activateIfOpen doesn't activate if open
3 participants