Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

SOCKS5 authentication broke Windows build #555

Open
riastradh-brave opened this issue Mar 30, 2018 · 0 comments
Open

SOCKS5 authentication broke Windows build #555

riastradh-brave opened this issue Mar 30, 2018 · 0 comments

Comments

@riastradh-brave
Copy link
Contributor

@darkdh reports that merging #470 caused the attached output in the Windows build of muon.

Presumably v8_context_generator depends on //net somewhere, and the BUILD.gn for //net in src/net doesn't have the new host_port_pair_auth.cc &c. files which live under src/electron/chromium_src and which I added in src/electron/chromium_src/BUILD.gn. Exactly which gn file should be updated to fix this is not immediately clear to me.

windows-fail.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant