Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: inappmessage modal - icon & text not centered #92

Open
kosiara opened this issue Oct 23, 2024 · 1 comment
Open

[Bug]: inappmessage modal - icon & text not centered #92

kosiara opened this issue Oct 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kosiara
Copy link

kosiara commented Oct 23, 2024

Which Platforms?

Android

Which Flutter Version?

3.24.0

Which Braze Flutter SDK version?

11.1.0

Repro Rate

100% of time

Steps To Reproduce

Launch inapp message on Android

If an icon is placed it is moved to the left - instead of being centered.
Title text & content text is moved to the left - instead of being centered.

Screenshot 2024-10-23 at 11 27 01 AM

Expected Behavior

In inapp message on Android the icon should be centered. Title text & content text should be centered.

Screenshot 2024-10-23 at 11 29 23 AM

Actual Incorrect Behavior

There's a bug in
BRAZE_SDK_VERSION=32.1.0
the ISSUE is fixed in BRAZE_SDK_VERSION=33.0.0

Verbose Logs

No response

Additional Information

Modal_icon should NOT have android:textAlignment="viewStart" attribute.

<RelativeLayout
            android:id="@+id/com_braze_inappmessage_modal_image_layout"
            style="@style/Braze.InAppMessage.Layout.Image.Modal">
            <com.braze.ui.inappmessage.views.InAppMessageImageView
                android:id="@+id/com_braze_inappmessage_modal_imageview"
                style="@style/Braze.InAppMessage.Image.Modal"/>
            <TextView
                android:id="@+id/com_braze_inappmessage_modal_icon"
                android:textAlignment="viewStart"
                style="@style/Braze.InAppMessage.Icon.Modal"/>
        </RelativeLayout>

The issue was fixed in BRAZE_SDK_VERSION=33.0.0 here:
braze-inc/braze-android-sdk@f0df61c#diff-b507fa487f229614c138a1a396fc32016ea1b551700b83fdc112758b059c7e7dR33

Also bumping the SDK version to BRAZE_SDK_VERSION=33.0.0
causes a conflict in Kotlin version for a default flutter project.

master...kosiara:braze-flutter-sdk:master

/Users/.pub-cache/git/braze-flutter-sdk-f9fa4130745197ac5fa79ee5c80b9a21bae89bfd/android/src/main/kotlin/com/braze/brazeplugin/
BrazePlugin.kt: (549, 48): 
Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. 
The binary version of its metadata is 1.9.0, expected version is 1.7.1.

e: /Users/.pub-cache/git/braze-flutter-sdk-f9fa4130745197ac5fa79ee5c80b9a21bae89bfd/android/src/main/kotlin/com/braze/brazeplugin
/BrazePlugin.kt: (549, 21): Class 'com.braze.Braze.Companion' 
was compiled with an incompatible version of Kotlin. 
The binary version of its metadata is 2.0.0, expected version is 1.7.1.
@kosiara kosiara added the bug Something isn't working label Oct 23, 2024
@kosiara kosiara changed the title [Bug]: inappmessage modal - icon not centered [Bug]: inappmessage modal - icon & text not centered Oct 23, 2024
@hokstuff
Copy link
Collaborator

Hi @kosiara,

Thanks for raising this. We have noted the desire to bump Flutter's Android bindings to the latest 33.0.0 and will start the process for this. Once it is ready, we will notify this thread here.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants