Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ContentCardUIViewController default attributes are let - therefore we cannot modify them #144

Open
stefanosgavriil-sarmis opened this issue Oct 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@stefanosgavriil-sarmis
Copy link

Platform

iOS

Platform Version

18.0.1

Braze SDK Version

9.3.1

Xcode Version

Version 15.2 (15C500b)

Computer Processor

Apple (M1)

Repro Rate

100%

Steps To Reproduce

You cannot modify the default ContentCardUI at all (e.g. cornerRadius) since the default-property is a let and not a var.

Expected Behavior

defaults should not be let, so we can modify them.

Actual Incorrect Behavior

If you want to modify the default cornerradius for ContentCards eg. BrazeContentCardUI.ViewController.Attributes.defaults.cellAttributes.cornerRadius you can't modify it, because the defaults are let.

It works for example BrazeInAppMessageUI.ModalView.Attributes.defaults.dismissOnBackgroundTap = true because the defaults is var.

Verbose Logs

-

Additional Information

@stefanosgavriil-sarmis stefanosgavriil-sarmis added the bug Something isn't working label Oct 24, 2024
@hokstuff
Copy link
Collaborator

Hi @stefanosgavriil-sarmis,

Thanks for raising this! We have noted to make this change internally and will be in touch once it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants