regex_remap: Adjust regex recursion limit down due to crashes in testing. (apache#6819)

SolidWallOfCode · Damian Meden · commit efa085601779 · 2020-09-02T14:38:25.000+01:00
diff --git a/plugins/regex_remap/regex_remap.cc b/plugins/regex_remap/regex_remap.cc
@@ -394,7 +394,8 @@ RemapRegex::compile(const char *&error, int &erroffset)
     return -1;
   }
 
-  _extra->match_limit_recursion = 2047;
+  // POOMA - also dependent on actual stack size. Crashes with previous value of 2047,
+  _extra->match_limit_recursion = 1750;
   _extra->flags |= PCRE_EXTRA_MATCH_LIMIT_RECURSION;
 
   if (pcre_fullinfo(_rex, _extra, PCRE_INFO_CAPTURECOUNT, &ccount) != 0) {

Original file line number	Diff line number	Diff line change
`@@ -394,7 +394,8 @@ RemapRegex::compile(const char *&error, int &erroffset)`
`394`	`394`	`return -1;`
`395`	`395`	`}`
`396`	`396`
`397`		`- _extra->match_limit_recursion = 2047;`
	`397`	`+ // POOMA - also dependent on actual stack size. Crashes with previous value of 2047,`
	`398`	`+ _extra->match_limit_recursion = 1750;`
`398`	`399`	`_extra->flags \|= PCRE_EXTRA_MATCH_LIMIT_RECURSION;`
`399`	`400`
`400`	`401`	`if (pcre_fullinfo(_rex, _extra, PCRE_INFO_CAPTURECOUNT, &ccount) != 0) {`