Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] cover node's internal 'messageerror' event with tests #66

Open
naz opened this issue Dec 8, 2020 · 0 comments
Open

[test] cover node's internal 'messageerror' event with tests #66

naz opened this issue Dec 8, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@naz
Copy link
Member

naz commented Dec 8, 2020

Problem

Test coverage is turned off for messageerror events with a comment to fix it:

// NOTE: you cannot catch messageerror since it is a Node internal
// (if anyone has any idea how to catch this in tests let us know)

Research

Have started a discussion in node repository around best ways to handle such cases - nodejs/node#36333 (comment). The best advice to tackle it so far has been:

I would currently recommend just to emit the events directly

Next

Simulating these events directly as suggested would be a next thing to try here.

Note, opening up an issue here so it's easier to track progress and any information that comes up on this topic in the future.

@shadowgate15 shadowgate15 added the help wanted Extra attention is needed label Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants