Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route hints may contain local fees instead of remote #999

Closed
JssDWt opened this issue Jun 10, 2024 · 0 comments · Fixed by #1000
Closed

Route hints may contain local fees instead of remote #999

JssDWt opened this issue Jun 10, 2024 · 0 comments · Fixed by #1000
Assignees

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Jun 10, 2024

If greenlight doesn't include the lsp route hint in a normal invoice (no channel open), we currently add the local routing fees in the route hint rather than the remote routing fees.

Relevant code here:
https://github.com/breez/breez-sdk/blob/2ff9646d03eac9f737834fdaeedc871d640d9649/libs/sdk-core/src/greenlight/node_api.rs#L1693-L1696

The code there has to be updated to use the remote policy (another call to the cln api listchannels api probably) to include the remote policies.
Another, additional, option can be to replace routing fees with the fees coming from lsp_information if the hint was not in the invoice originally, but it is included in the get_routing_hints call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants