Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose response object #15

Open
HaNdTriX opened this issue Apr 18, 2018 · 1 comment
Open

Expose response object #15

HaNdTriX opened this issue Apr 18, 2018 · 1 comment

Comments

@HaNdTriX
Copy link

First of all thanks a lot for this nifty crawler. I am really enjoying your api design!

Nevertheless, would it be possible to expose the entire response object in the handler api? Currently supercrawler only exposes contentType, response.body and url.

This would allow us to crawl a lot more information:

  • crawl response headers
  • handle http status codes/messages
  • performing custom redirects

I can create a PR if such a change would be acceptable.

@brendonboshell
Copy link
Owner

Yes, I would accept a pull request for this provided the change was backwards compatible. Adding a response property to the ctx object seems the most obvious route?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants