Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Sample name function can be useful #19

Closed
idraktt opened this issue Feb 18, 2019 · 3 comments
Closed

--Sample name function can be useful #19

idraktt opened this issue Feb 18, 2019 · 3 comments

Comments

@idraktt
Copy link

idraktt commented Feb 18, 2019

Dear Brent,

First i want to say thank for that beatiful tool. We are implementing duphold filtration step in our cnv calling pipeline and it really helps to remove FPs. Unfortunately we came across with one issue when sample name in our snp vcf file is not the same as a SM tag in the BAM file. (Filename used for SAMPLE column in vcf file). Is it possible to add extra input parameter that will specify sample name to look for in snp vcf file?

@brentp brentp closed this as completed in 43ce4c7 Feb 19, 2019
@brentp
Copy link
Owner

brentp commented Feb 19, 2019

I have just pushed a fix for this that allows the name to be set via the environment variable DUPHOLD_SAMPLE_NAME. This will be out in the next release.

Thanks for reporting.

@idraktt
Copy link
Author

idraktt commented Feb 20, 2019

Thank you very much Brent for your help.

@brentp
Copy link
Owner

brentp commented Apr 22, 2019

this is added, sorry for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants