bug: Change in behaviour of connection string parsing

[domdomegg]

Bug hasn't been fully confirmed yet, but I suspect there is an issue with the recent changes to pg-connection-string.

I think f305419 (PR #2971) may have inadvertently changed the behaviour of connection string parsing, for strings of the form:

postgresql://myuser:mypass@localhost/mydb?host=/cloudsql/my-project:europe-west2:my-sql-instance

This style connection string I believe was previously recommended in the Google Cloud docs for connecting to Google Cloud SQL instances, because the host includes forward slashes (although might not not have been, and doesn't seem to be the case any more).

[domdomegg]

Keywords for searchability:

• database "localhost/dbname" does not exist
• Google App Engine
• Google Cloud SQL Node.js connection string

[elithrar]

cc @petebacondarwin

[Qrtn]

I'm also experiencing this (database "localhost/dbname" does not exist) when using Google Cloud SQL Auth Proxy.

Additionally, when the password contains an @ sign, I can't get percent-sign encoding to work anymore (%40 for @).

I've pinned pg@8.10.0 and pg-connection-string@2.5.0 for now to resolve this issue.

[petebacondarwin]

@Qrtn - hopefully the PR put together by @domdomegg will solve the Google Cloud SQL connection string problem.

Can you provide a reproduction of when an encoded @ in the password doesn't work?
There is this test that is passing in the code: https://github.com/brianc/node-postgres/blob/master/packages/pg-connection-string/test/parse.js#L120