Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show replay button if video completes for Android OS #228

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

manikandn
Copy link
Contributor

Closes: #88

@nstrelow
Copy link
Collaborator

nstrelow commented Nov 9, 2020

Hey thanks for the PR. Very on the point change.
If I am seeing this correctly, your PR changes the Icon when the video is finished.

The Issue you linked asked to reset the video to the beginning. Can you implement that as well?
And it would be great to also have the same for iOS. Maybe you can provide the code and somebody else can test it, if you do not have a Mac machine?

@nstrelow
Copy link
Collaborator

nstrelow commented Nov 9, 2020

Upgraded the branch to newest chewie

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 10, 2020

@manikandn for the Full implementation you can have a look here:

Material: https://github.com/Ahmadre/chewie_extended/blob/master/lib/src/material_controls.dart

There's also an AnimatedIcon for Play/Pause. It would be great if we can also have this, but it's optional. The replay function is more important here 👍🏼

@manikandn
Copy link
Contributor Author

@nstrelow Required changes are done and also tested in iOS as well. Please have a look.

@Ahmadre Thanks for the suggestion.

@Ahmadre Ahmadre merged commit 1a5f48e into fluttercommunity:master Nov 12, 2020
@manikandn manikandn deleted the issue_88 branch November 12, 2020 17:46
@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 12, 2020

New version is online: Version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay button on video finish
4 participants