Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required Flutter version 1.20 -> 1.22 #401

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

daohoangson
Copy link
Contributor

Since 971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in pubspec.yaml so app developers can upgrade their Flutter installation.

Since fluttercommunity@971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in `pubspec.yaml` so app developers can upgrade their Flutter installation.
@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 20, 2020

Since 971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in pubspec.yaml so app developers can upgrade their Flutter installation.

Could you please fix the Lint errors? The checks must pass, then we can merge this :). Thanks

@nstrelow
Copy link
Collaborator

Since 971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in pubspec.yaml so app developers can upgrade their Flutter installation.

Could you please fix the Lint errors? The checks must pass, then we can merge this :). Thanks

@Ahmadre The lint issues were caused by a previous PR. I will fix them shortly.
Would be unfair to have the @daohoangson fix lint errors of others

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 20, 2020

Since 971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in pubspec.yaml so app developers can upgrade their Flutter installation.

Could you please fix the Lint errors? The checks must pass, then we can merge this :). Thanks

@Ahmadre The lint issues were caused by a previous PR. I will fix them shortly.

Would be unfair to have the @daohoangson fix lint errors of others

Oh sure! Didn't encountered that, sorry for the quick merge on my side! Had to double check it!

@daohoangson
Copy link
Contributor Author

Thanks @nstrelow for the pointer, I was a bit surprised that a pubspec bump introduced a lint error. So is this PR good to merge now? I can fix the lint error in this PR too, if you want @Ahmadre.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 20, 2020

Thanks @nstrelow for the pointer, I was a bit surprised that a pubspec bump introduced a lint error. So is this PR good to merge now? I can fix the lint error in this PR too, if you want @Ahmadre.

@nstrelow has already fixed this :) After the checks are done I'll merge this.

@nstrelow
Copy link
Collaborator

maeh we need to rebase first
I would merge now, it should be fine and if not, it's not this PRs fault

@daohoangson
Copy link
Contributor Author

Ah you guys are fast. I have merged upstream into my branch. CI should be green now.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 20, 2020

maeh we need to rebase first
I would merge now, it should be fine and if not, it's not this PRs fault

haha yeah sure I wanted to rebase and update this branch, but he was faster XD hahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants