Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Error compiling when using v8 3.29 #144

Closed
waTeim opened this issue Jan 12, 2015 · 2 comments
Closed

Error compiling when using v8 3.29 #144

waTeim opened this issue Jan 12, 2015 · 2 comments

Comments

@waTeim
Copy link

waTeim commented Jan 12, 2015

Hi all, I'm working on combining atom-shell, Julia, and d3 to be used as a data visualizer. D3 needs contextify, but the problem is that the released versions of node use a earlier version of v8.

node 0.10.35:    3.14.5.9
node 0.11.13:    3.25.30
node 0.11.14:    3.26.33
atom-shell:      3.29.88.17

In v8 3.29, the function ContextDisposedNotification is no longer a static member function of the class V8, but rather a member function of v8::Isolate, and so contextify.cc will not compile

 CXX(target) Release/obj.target/contextify/src/contextify.o
../src/contextify.cc:31:13: error: no member named 'ContextDisposedNotification' in namespace 'v8'

Luckily atom-shell provides sufficient defines to conditionally compile

@valer-cara
Copy link

@domenic
Copy link
Collaborator

domenic commented Jan 26, 2015

Consolidating into #149.

@domenic domenic closed this as completed Jan 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants