Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid short month names in LV #2479

Closed
ozldmezot opened this issue Oct 22, 2021 · 4 comments · Fixed by #2478
Closed

Invalid short month names in LV #2479

ozldmezot opened this issue Oct 22, 2021 · 4 comments · Fixed by #2478
Labels
translation Rely to internationalization

Comments

@ozldmezot
Copy link
Contributor

ozldmezot commented Oct 22, 2021

Hello,

I encountered an issue with the following code:

 'months_short' => ['Janv', 'Feb', 'Mar', 'Apr', 'Mai', 'Jūn', 'Jūl', 'Aug', 'Sept', 'Okt', 'Nov', 'Dec'],

in file src/Carbon/Lang/lv.php

Carbon version: 2.53.1

PHP version: irrelevant

Expected values are:

'months_short' => ['Janv', 'Febr', 'Martā', 'Apr', 'Maijā', 'Jūn', 'Jūl', 'Aug', 'Sept', 'Okt', 'Nov', 'Dec'],

based on the legislation "Par mēnešu nosaukumu saīsinājumiem latviešu valodā"

P.S.
I created a pull request: #2478

@kylekatarnls
Copy link
Collaborator

kylekatarnls commented Oct 22, 2021

Hello 👋

According to https://likumi.lv/ta/id/281651-par-menesu-nosaukumu-saisinajumiem-latviesu-valoda this should also be lower case and with the trailing dot.

So I would opt for:

'months_short' => ['janv.', 'febr.', 'marts', 'apr.', 'maijs', 'jūn.', 'jūl.', 'aug.', 'sept.', 'okt.', 'nov.', 'dec.'],

Can you tell why marts becomes martā and maijs becomes maijā? If there are multiple possible ending depending on the context, then we should probably keep the abbreviated versions.

@kylekatarnls kylekatarnls added the translation Rely to internationalization label Oct 22, 2021
@ozldmezot
Copy link
Contributor Author

ozldmezot commented Oct 22, 2021

You are absolutely correct, there could be multiple possible endings depending on the context, however, since marts and maijs are not abbreviated I figured they should mimic the ending from months key

I see you also suggested adding dots at the end of abbreviations, good catch

@ozldmezot
Copy link
Contributor Author

In my honest opinion, mimicking months key makes more sense, than introducing invalid abbreviation

@ozldmezot
Copy link
Contributor Author

Switched to lowercase and suffixed with dot where needed in the PR as suggested by @kylekatarnls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants