-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid short month names in LV #2479
Comments
Hello 👋 According to https://likumi.lv/ta/id/281651-par-menesu-nosaukumu-saisinajumiem-latviesu-valoda this should also be lower case and with the trailing dot. So I would opt for: 'months_short' => ['janv.', 'febr.', 'marts', 'apr.', 'maijs', 'jūn.', 'jūl.', 'aug.', 'sept.', 'okt.', 'nov.', 'dec.'], Can you tell why |
You are absolutely correct, there could be multiple possible endings depending on the context, however, since I see you also suggested adding dots at the end of abbreviations, good catch |
In my honest opinion, mimicking |
Switched to lowercase and suffixed with dot where needed in the PR as suggested by @kylekatarnls |
Hello,
I encountered an issue with the following code:
in file src/Carbon/Lang/lv.php
Carbon version: 2.53.1
PHP version: irrelevant
Expected values are:
based on the legislation "Par mēnešu nosaukumu saīsinājumiem latviešu valodā"
P.S.
I created a pull request: #2478
The text was updated successfully, but these errors were encountered: