PHP 8.2 - utf8_encode deprecated

[systemsolutionweb]

Hello,

I encountered an issue with the following code:
utf8_encode() deprecated

Carbon/src/Carbon/Traits/Date.php

Line 1856 in 88ac19c

return static::$utf8 ? utf8_encode($formatted) : $formatted;

Carbon version: latest

PHP version: 8.2

https://php.watch/versions/8.2/utf8_encode-utf8_decode-deprecated

Suggestion:

return static::$utf8 ? (function_exists('mb_convert_encoding') ?
    mb_convert_encoding($formatted, 'UTF-8', mb_list_encodings()) :
    utf8_encode($formatted)) : $formatted;

Thanks!

[kylekatarnls]

Hi, thanks for the report. mb_convert_encoding is recommended as a replacement in the official documentation so your suggestion is good.

As the Carbon method formatLocalized it's in is also deprecated, we'll get rid of all that in a later version.

Would you mind to create a pull-request for it?

Maybe indent both ternary for readability:

return static::$utf8
    ? (function_exists('mb_convert_encoding')
        ? mb_convert_encoding($formatted, 'UTF-8', mb_list_encodings())
        : utf8_encode($formatted)
    )
    : $formatted;