Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request / Question: allow a configuration for the number of "connections" #543

Open
ramarivera opened this issue Apr 16, 2024 · 1 comment

Comments

@ramarivera
Copy link

From what I can understand, right now the number of connections to a note is a filter param, but pretty much uses the default of 20 always

.

WDYT about allowing this param to be set in the configuration of the plugin?

If you agree, I can also offer to raise a PR :)

@brianpetro
Copy link
Owner

Hey @ramarivera

I do agree that this should be configurable.

I plan to implement the filters (mentioned in #544 (comment)) by creating an overlay UI on the Smart View. One reason is that the settings page is already getting pretty crowded, so I think it makes sense to move some of the settings to the Smart View component itself. Same with the Smart Chat.

In the meantime, adding this as a main setting might make sense, but I think we should wait to make the change until v2.1 is in general release. That smart_entities code is being extracted into its own module, so that file will be removed/replaced. I also have a new settings file for v2.1. So if we wait, then we won't have to re-do anything.

But overall, great idea. And I appreciate all the feedback you;ve been giving to help make Smart Connections the best it can be 😊

🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants