You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are some test cases in pbkdf2_tests.txt that are commented out because they are invalid inputs for ring's PBKDF2 module. In particular, they request an output longer than the output length of the the digest function being used. We should turn those test cases into the equivalent of [should_panic]. AFAICT, this means we need to:
Uncomment those test cases.
Annotate those test cases with "FAILS: OUTPUT_LARGER_THAN_DIGEST_OUTPUT".
Change the testing code so that for the cases marked "FAILS: OUTPUT_LARGER_THAN_DIGEST_OUTPUT", a task gets spawned that does the test case. We have to wait for the task to end and then verify that it was ended due to a panic!. In other words, we need to create the equivalent of a [should_panic] test.
Additionally, we should add more test cases, particularly a test case for iterations == 0, as BoringSSL has (had) a bug when interations == 0.
AFAICT, this is complicated by rust-lang/rust#25869, as I believe we cannot do [should_panic] tests or create a data-driven alternative to [should_panic] on Win32 since Rust on Win32 doesn't implement panic! correctly; `panic!`` just kills the entire process. We should probably just work around that by not running these tests on Win32.
The text was updated successfully, but these errors were encountered:
Yes, you're right, given the description above. However, we should add a #[should_panic] test for the case where iterations == 0, which is the remaining case that can panic.
Currently there are some test cases in pbkdf2_tests.txt that are commented out because they are invalid inputs for ring's PBKDF2 module. In particular, they request an output longer than the output length of the the digest function being used. We should turn those test cases into the equivalent of
[should_panic]
. AFAICT, this means we need to:panic!
. In other words, we need to create the equivalent of a[should_panic]
test.Additionally, we should add more test cases, particularly a test case for
iterations == 0
, as BoringSSL has (had) a bug wheninterations == 0
.AFAICT, this is complicated by rust-lang/rust#25869, as I believe we cannot do
[should_panic]
tests or create a data-driven alternative to[should_panic]
on Win32 since Rust on Win32 doesn't implementpanic!
correctly; `panic!`` just kills the entire process. We should probably just work around that by not running these tests on Win32.The text was updated successfully, but these errors were encountered: